Skip to content

update assert-json-diff and thiserror major versions #4148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

arielb1
Copy link

@arielb1 arielb1 commented May 25, 2025

Motivation and Context

this repo uses assert-json-diff 1 and thiserror 1, which are deprecated

Description

updated them to avoid using deprecated packages

Testing

no intended changes, ran auto tests


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@landonxjames
Copy link
Contributor

Canary run for this change: https://github.com/smithy-lang/smithy-rs/actions/runs/15284652924

@arielb1
Copy link
Author

arielb1 commented May 27, 2025

Is this an actual CI failure? What is it caused by?

I see this:

`proc-macro-error` (1.0.4), used by `aws/rust-runtime/Cargo.lock`, is not contained in the SDK lockfile!

@landonxjames
Copy link
Contributor

Is this an actual CI failure? What is it caused by?

That happens sometimes with changes that update the individual workspace Cargo.lock files. You can hopefully get around it by running ./gradlew aws:sdk:cargoUpdateAllLockfiles from the root of the repo.

The other failure should also be easy to fix, just do a patch version bump in each of the crates where you changed a dependency.

@arielb1
Copy link
Author

arielb1 commented May 27, 2025

Updated, can you re-run CI?

@arielb1
Copy link
Author

arielb1 commented May 28, 2025

So this just needs a canary run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants