update assert-json-diff and thiserror major versions #4148
Merged
+361
−417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Canary run for this change: https://github.com/smithy-lang/smithy-rs/actions/runs/15284652924 |
|
Is this an actual CI failure? What is it caused by? I see this: |
That happens sometimes with changes that update the individual workspace The other failure should also be easy to fix, just do a patch version bump in each of the crates where you changed a dependency. |
|
Updated, can you re-run CI? |
|
So this just needs a canary run? |
landonxjames
approved these changes
May 28, 2025
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
this repo uses assert-json-diff 1 and thiserror 1, which are deprecated
Description
updated them to avoid using deprecated packages
Testing
no intended changes, ran auto tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.